chore: run container as non-root user and add healthcheck#2934
chore: run container as non-root user and add healthcheck#2934RinZ27 wants to merge 1 commit intosmithy-lang:mainfrom
Conversation
|
This pull request does not contain a staged changelog entry. To create one, use the Make sure that the description is appropriate for a changelog entry and that the proper feature type is used. See |
|
@mtdowling That's a fair point. Since this is primarily a short-lived CLI tool rather than a long-running service, the healthcheck is indeed redundant overhead. I'll go ahead and remove it. |
RinZ27
force-pushed
the
chore/docker-hardening
branch
from
cd20e38 to
0e891c9
Compare
|
The health check still seems to be there |
RinZ27
force-pushed
the
chore/docker-hardening
branch
from
0e891c9 to
2368502
Compare
|
My apologies for the oversight. I've updated the Dockerfile to remove the |
3 participants
I've split out the Docker hardening changes as discussed in #2933.
This PR updates the Dockerfile to:
smithyuser. I also made sure tochownthe/smithydirectory so the new user has the right permissions to run the CLI and manage its class data sharing archive.HEALTHCHECKusingsmithy --versionto monitor container health.I think this covers what we talked about for the container side of things. Let me know if you want any further tweaks to the setup!